Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component

@YuriMascarenhasLourenco

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


how can i make my code cleaner?

did i use the best practices at this project?

Every advice is welcome!

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • let me explain, How you can easily apply the background color with the svg they provided.
  • Add the following style rule to your css, and then experience the changes
body {
    background: url(/pattern-background-desktop.svg), #E1E9Ff;
    background-repeat: no-repeat, no-repeat;
}
  • Tip, Don't forget to generate a new screenshot after editing the css file

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@YuriMascarenhasLourenco

Posted

@0xAbdulKhalid I made the changes, thanks for the tip!

0
Vanza Setia 27,795

@vanzasetia

Posted

Hi, Yuri Mascarenhas Lourenço!

I recommend only having one <link> tag to import the font family. There are three <link> tags at the moment.

The music icons and the illustration are decorative images. Meaning, they don't add any useful information. I recommend leaving the alternative empty for both images. This way, screen reader users can skip the images to save time.

I hope this helps.

Marked as helpful

0

@YuriMascarenhasLourenco

Posted

@vanzasetia I appreciate the tip. I will change this project and implement this in future projects

0
P
visualdennis 8,375

@visualdenniss

Posted

Hey, good job there!

Regarding backround, it seems like it is not where it should be. So

  • remove this: background-position: center;

  • Instead use background-size: 100%; instead of cover, this should get you closer to the design look.

  • Also all interactive elements should have some change on hover to indicate interactivity to the user. The most basic is cursor:pointer; like you have for 'change'. But adding a background change to the button on hover is also big plus. (if the button does not have any bg like 'cancel order' you can just change the font-color or add text-underline etc)

Hope you find this feedback helpful!

Marked as helpful

0

@YuriMascarenhasLourenco

Posted

@visualdenniss I hadn't thought of that before, thanks for the tip. I hope to continue counting on your help!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord