Melvin Aguilar ๐ง๐ปโ๐ปโข 61,220
@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of
400px
or25rem
to make sure that the component will have a maximum width of400px
on any device, also remove thewidth
property with a percentage value.
- The music icon and the hero-image are for decoration purposes only, so they could be hidden from screen readers by leaving its alt attribute empty.
- In this challenge, it's preferable to represent the "change" element as a button rather than an anchor tag. Buttons are designed for action initiation, and in this case, the action involves altering the order's plan. This makes a button a more suitable choice than an anchor tag typically used for linking.
I hope you find it useful! ๐
Happy coding!
Marked as helpful
0
pbgo2โข 60
@pbgo2
Posted
hi @MelvinAguilar Thank you so much for such tips) really helping, Have you good day!
1