Order Summary Component Using CSS and HTML

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  • Not all images should have alt text. Music icon and the hero image are for decoration purposes only, so they can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:

  <img class="hero-image" src="illustration-hero.svg" alt="" aria-hidden="true" />
  <img class="icon-music-img" src="icon-music.svg"  alt="" aria-hidden="true" />
  

  • Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this two lectures:

  1. The Surprising Truth About Pixels and Accessibility - The 62.5% trick
  2. A comment on the 62.5% trick

  Credit to grace-snow and vanzasetia for pointing this out.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Felipe Mata•230

  @BoxyPipesnakePosted almost 2 years ago

  @MelvinAguilar thanks for your feedback!!

  1