Design comparison
SolutionDesign
Solution retrospective
Any suggestions or feedback are welcomed. Thank you!
Community feedback
- @vanzasetiaPosted about 2 years ago
Hello, Tham Jia Jun! 👋
Well done on this challenge! The HTML is already well structured. One suggestion for the HTML is to specify the
type
of thebutton
elements. In this case, set the type of them astype="button"
. It will prevent the button from behaving unexpectedly.For the styling,
- Add some
padding
to thebody
element. It will prevent the card from touching the edges of the browser. - Code your font size in rem, not pixels. This means the text size will be responsive if people want to adjust the size.
- Create a custom
:focus-visible
styling for any interactive elements (e.g.button
, links,input
,textarea
). This will let people who use a keyboard to navigate the site know where they are currently on the page.
I hope you find this useful!
0 - Add some
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord