Order Summary Card

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  the proceed-btn must have a box-shadow.

  Since you used max-width your content is is responsive in the media query you only have to change the background-image.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Alex Garcia 🦝 Garcialexco•440

  @garcialexcoPosted almost 2 years ago

  @Hassiai Thank you very much for your help! I was struggling with centering items on the page, Flexbox and Grid layouts have been a little confusing to me. Thank you again, super helpful!

  1
• 

  Thabiso•270

  @SefalaThabisoPosted almost 2 years ago

  You should have used h1 instead of h2. And I would recommend using h2 instead of h5 but I don't know if using h5 is good for accessibility. I always try to go from h1 -> h2> h3 > h4. Your page should have atleast one h1 tag but not more than one.

  Adding link in html for Google fonts is better than @import. Link is loads faster that import

  I might be bit wrong as I'm a beginner 😅. This are some of the mistakes I did before 😌

  Marked as helpful

  0

  ---

  

  Alex Garcia 🦝 Garcialexco•440

  @garcialexcoPosted almost 2 years ago

  @SefalaThabiso Thank you! I wasn't sure about it, it makes sense because you can just adjust the sizing with CSS :p Also, I didn't know that about Google fonts. I'll be sure to use link from now on lol

  1