HTML and CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  There is no need to give the body a width value and a max-width value in the body.

  Give .main a background-color of white, a max-width value instead of a width value. for more a responsive width. There is no need to give .main a height value.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful. HAPPY CODING

  Marked as helpful

  1
• 

  Uve•90

  @sjannnPosted almost 2 years ago

  Hey friend👋, I recommend you take a look at this article, it was very useful for me to learn different ways when it comes to learning to center elements.

  https://www.freecodecamp.org/news/how-to-center-a-div-with-css-10-different-ways/

  You can review my solutions and leave me feedback, it is always very grateful.

  Happy Code!!🚀

  Marked as helpful

  1
• 

  David•8,000

  @DavidMorgadePosted almost 2 years ago

  Hello Daniel, congrats on finishing the challenge!

  You are doing good using display: grid place-items: center on your parent component, the problem is that setting a max-width: 1440px on your body will limit the width of the component, not getting centered, you should remove hardcode widths on your body.

  Apart from that you could also use display: flex justify-content: center align-items: center to center your component from the parent element.

  Marked as helpful

  1

  ---

  

  Daniel•50

  @trevisandanielPosted almost 2 years ago

  @DavidMorgade Thank you for the response!

  1