Order Summary Component

Community feedback

• 

  P

  Robert McGovern•1,075

  @tarasisPosted almost 3 years ago

  Hi wave I would be helpful if you made your code repo's public :) Solution looks good.

  Partly just passing on helpful info from Grace that she said to me on my attempt at this. Specifically ...

  <p class="link">Change</p> What is the intention of Change? For the user to press it and effect some difference to what's already there so it should be a button. Likewise the Proceed to Payment and Cancel fields should be links (masquerading as buttons) rather than Paragraphs

  You nailed what I didn't, namely having the Price/Term beside the icon and away from the Change button.

  Drop the background-size: cover & background-position: center you don't need them, and it will make the background closer to the design images.

  For the media query, I'd recommend breaking at 376 not min-width: 750px, the mobile SVG is limited to 375px in size so between 376px and 749px you'll be left with a blank area to the side of the SVG.

  Marked as helpful

  1

  ---

  

  Amelia Thomas•120

  @riemann0Posted almost 3 years ago

  @tarasis

  Hi Robert!

  Much appreciated. I think I will soon set up a separate Git profile in order that I can make my solutions on here public. I basically don't want it to get too cluttered in my personal repo.

  Thank you for the helpful information. It is very much appreciated!

  I will drop those components and let you know once it is done.

  Once again, thank you very much.

  Kindest regards, Amelia

  0

  

  P

  Robert McGovern•1,075

  @tarasisPosted almost 3 years ago

  @riemann0 I look forward to it. BTW An option is create a single repo for Frontend Mentor challenges, and then just put all your solutions in it. Its what I've been doing (and using it for publishing the solutions too). See https://github.com/tarasis/tarasis.github.io

  That way you keep your profile tidy, but you are showing activity (for those that might care) and you can point potential employers too it without having to explain why you have multiple accounts.

  Best wishes, and good luck with your next challenge!

  0

  

  Amelia Thomas•120

  @riemann0Posted almost 3 years ago

  @tarasis This is great advice! Thank you very much.

  Good luck with your next challenges also.

  0