Order Summary Component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Remove article and section elements, they are being used incorrectly ❌.

  • The “illustration” and "music icon" in this component are purely decorative. ⚠️ Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  MDN Aria-Hidden

  • The only heading ⚠️ in this challenge is the ”Order Summary". Every other text should wrapped in a paragraph element.

  • Your CSS Reset is being underutilized. 😢 To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1

  ---

  

  Richard Tom•80

  @CryptoFallenPosted almost 2 years ago

  @vcarames that is very helpful, I’ll look into those suggestions and make changes accordingly. I’m still trying to figure out when to use semantic or not for situations like these.

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @CryptoFallen

  Glad I could help! 😁

  The article element will be rarely used. Yahoo is a good example of components that will use the article element since you practically select anything in their site and it sense on its own without additional info.

  While the section is for a complete website to group content of similar context. Think of it like book chapters; each chapter is a section.

  Marked as helpful

  1

  

  Richard Tom•80

  @CryptoFallenPosted almost 2 years ago

  @vcarames thank you, will definitely have to look into semantics a lot more and when to use just diva with class only instead.

  0