Design comparison
Solution retrospective
Any feedback is appreciated. Thanks in advance.
Community feedback
- @HassiaiPosted almost 2 years ago
wrap <div class="attribution"> in a footer tag to fix the accessibility issue.
Increase the max-width of .payment to 400px; You forgot to add a background-image, with a background-size of contain and a background-repeat of no-repat to the body. repeat this for the body in the mobile design by adding a media query. e.g.
body{ background-image: url(); background-size: contain; background-repeat: no-repeat; }
Hope am Helpful
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@cyberweb8Posted almost 2 years ago@Hassiai Thank you for your feedback. I have a question to ask, if you don't mind. Why background-size should be contain. If I do cover it disappears.
0@HassiaiPosted almost 2 years ago@cyberweb8, when the background-size: contain is used the background-image stretches across the entire width of the screen/page.
when the background-size: cover is used the background image fully covers or occupies the whole page.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord