Design comparison
Solution retrospective
All feedback is welcome thank you in advance ))
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag and <h3> with <h2> to fix the accessibility issues. click here for more on web-accessibility and semantic html
There is no need to give the body a width value .
You forgot to give the body a background-image with a background-size of contain a nd a background-repeat of no repeat.
Since you gave .container a width value in the media query you only have to change the background-image of the body.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord