Design comparison
SolutionDesign
Solution retrospective
What are some bad coding practices do you see, that I should improve on??
Community feedback
- @eewa-SANJPosted almost 2 years ago
Hello!. Your solution looks fantastic and looks exactly like the design. Here are fix issues I found
- You use mixed units such as %, em, rem, and px. Try to use rem with one other in order to maintain consistency.
- Order your CSS style properties in an alphabetical way. So, its readability will increase.
That's it. I think, my findings will help you to improve your coding.
Happy coding😊
Marked as helpful1@hello-sabiraPosted almost 2 years ago@eewa-SANJ Hello, thank you so much for your detailed feedback :)) Yes, I'm still a bit confused with the units, you're right. I should stick to two. Also, I like the point about ordering CSS style properties in an alphabetical way, never thought about this before.
Thanks a lot once again!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord