Sanjeewa Marukona• 200
@eewa-SANJ
Posted
Hello!. Your solution looks fantastic and looks exactly like the design. Here are fix issues I found
- You use mixed units such as %, em, rem, and px. Try to use rem with one other in order to maintain consistency.
- Order your CSS style properties in an alphabetical way. So, its readability will increase.
That's it. I think, my findings will help you to improve your coding.
Happy coding😊
Marked as helpful
1
Sabira K.• 80
@hello-sabira
Posted
@eewa-SANJ Hello, thank you so much for your detailed feedback :)) Yes, I'm still a bit confused with the units, you're right. I should stick to two. Also, I like the point about ordering CSS style properties in an alphabetical way, never thought about this before.
Thanks a lot once again!
1
