Order Summary Component

Community feedback

• 

  Shuaib•640

  @JustShuaibPosted over 2 years ago

  Hi there, going through your solution now and I wanted to point out a few things.

  Always wrap all your contents in a (landmark tag)[https://www.w3.org/TR/wai-aria-practices/examples/landmarks/HTML5.html] .

  You used an h1 and h4. You do not have h2, h3, h4. Ideally, your headings should follow a descending chronologic order. i.e after h1, you should have h2 and not h3 or h4. Instead of using a h4 here, you could use a p or span.

  Also, you change btn's font is arial. You should include font: inherit to the button or use a different tag. An a should be ideal here.

  You included

    
    html {
      font-size: 40%;
    }
  
    .card {
      flex-shrink: 0;
    }
  }
  

  at the end of your code. Generally, it is better to include your media queries close to the class/element you're adding the query to as it is easier to debug.

  You should also look through the accessibility and HTML issues after submitting your response on FEM, it gives you a heads up on possible things to imporve.

  Happy coding!

  Marked as helpful

  0

  ---

  

  Oleksandr•90

  @kirinyokuPosted over 2 years ago

  @JustShuaib Thanks for paying attention to my work, next time I'll take your advice.

  0