Design comparison
SolutionDesign
Community feedback
- @eewa-SANJPosted almost 2 years ago
Your solution is pretty amazing, here are some of the issues I have found,
- When you put an img alt tag, you have to consider the image purpose in order to meet accessibility reasons.
<img src="images/icon-music.svg" alt=" hero"> here, the image is only for decorative purposes, so you can leave the alt blank because the screen reader has no sense of putting the image alt.Hence you can put img tag like this <img src="images/icon-music.svg" alt aria-hidden="true">
- Your "Proceed to the payment" button hover effects are much different than the original design file.
- Also, you do not apply the shadow effect to the "Proceed to payment" button
- Also, you can use rem or em values instead of px values in order to apply relative measurement(Only suggestion)
- Put cursor: pointer for anchor tags
Happy coding😊
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord