Design comparison
Solution retrospective
I feel like I wrote too much CSS for this component, any feedback will be appreciated. Thank you!
Community feedback
- @brodiewebdtPosted almost 3 years ago
Some things you think will be simple take a lot more code than you think. The more projects you do, you be able to use less code to design them. The Annual plan section should be the same width as the button below it. The Change text need to be styled as well.
Wrap your mainContainer div in a Main tag and it will clear the accessibility warnings.
Download AXE DevTools and you can clear accessibility warnings while you code. https://www.deque.com/axe/devtools/
Hope this helps.
Marked as helpful1@meladcodesPosted almost 3 years ago@brodiewebdt Hi, thank you for the feedback and advice. I will try to implement them!
1 - @Jennifer1919Posted almost 3 years ago
Hi! Here is an advice if you want to reduce the amount of line in you css file:
- instead of writing border-top-right-radius: 10px; border-top-left-radius: 10px; you can just write border-radius: 10px 10px 0px 0px; and it will do the same thing
- you can do the same thing for margin-right: 30px; margin-left: 8px; just set it to margin: 0px 30px 0px 8px;
here are some links to help you: https://www.w3schools.com/css/css_margin.asp https://www.w3schools.com/css/css_border_width.asp
Marked as helpful1@meladcodesPosted almost 3 years ago@Jennifer1919 Thank you so much for the feedback! I will surely implement that.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord