Design comparison
Solution retrospective
An extra project to do!
I enjoyed working on this project, it was very interesting, the only downside I have is that I don't know how to centre the map in the centre of the screen...
If you see any problems in my code, please let me know!
I'm looking for any tips or tricks that would help me improve my program and my skills.
Thanks in advance ^^
Community feedback
- @denieldenPosted almost 2 years ago
Hello Aliho, You have done a good work! 😁
Some little tips to improve your code:
- To fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- remove all
margin
fromcard
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful1@A-l-i-h-oPosted almost 2 years agoThank you very much for your valuable advice, it has helped me a lot.
But I still can't get the card element to centre on the screen. ^^'
1@denieldenPosted almost 2 years ago@A-l-i-h-o You are welcome and keep it up :)
Why you can't get the card element to centre on the screen??
1@A-l-i-h-oPosted almost 2 years ago@denielden That's it! I managed to centre the Card element! Thanks a lot!
Thanks to your advice :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord