Order summary component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @keyztrokee, some suggestions to improve you code:

  • Currently you HTML Code isnt structured and your using certain elements incorrectly. To better structure your content and make it a lot clearer, you want to implement Semantic HTML.

  Why use Semantic HTML?

  1. Accessibility: Semantic HTML makes webpages accessible for mobile devices and for people with disabilities as well. This is because screen readers and browsers are able to interpret the code better.
  2. SEO: It improves the website SEO, or Search Engine Optimization, which is the process of increasing the number of people that visit your webpage. With better SEO, search engines are better able to identify the content of your website and weight the most important content appropriately.
  3. Easy to Understand: Semantic HTML also makes the website’s source code easier to read for other web developers.

  • Add the following to your Body Element to fix your background.

  body {
      background-size: 100%;
      background-position: contain;
  }
  

  • The Alt Tag in the main image isnt being used effectively. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  • The music icon is decorative, so its Alt Tag can be left blank.

  • To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  More Info:

  https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

  https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

  • To keep your CSS code organized and easier to use, I suggest implementing CSS Variables. This will come in handy when building large websites, using light/dark mode, etc…

  More Info

  https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

  https://www.w3schools.com/css/css3_variables.asp

  Happy Coding!

  Marked as helpful

  0

  ---

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vcarames Thank you so much! I'll try to read it later.

  0

  

  Raymond Fajiculay•230

  @keyztrokeePosted about 2 years ago

  @vcarames Hi again, I made some changes, would you mind taking a look at it if I have done what you suggest the right way? I hope you can find time to take a look at it. Thank you very much!

  0