My "Order summary component"

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  • How do I change the background image from mobile to desktop - r/ using a media query.

  @media screen and (max-width: 36em) {
    body {
      background-image: url("images/pattern-background-desktop.svg");
    }
  }
  

  • how do I remove the scrollbar but keep all the body elements in the middle - r/ Use padding: 1rem; instead of margin: 1rem; on the body to remove the scrollbar

  • Not all images should have alt text. The illustration-hero and music-icon are for decoration purposes only. In this case, you can add aria-hidden="true" to the element and leave the alt attribute blank.

    Adding aria-hidden="true" to an image will prevent it from being read by screen readers. This is useful when the image is purely decorative and does not convey any information that needs to be communicated to the user.

    <img src="./images/illustration-hero.svg" alt aria-hidden="true" class="card__image">
    

    You can read more about this here 📘

  • There is a debate about what is the best type of elements for this challenge, but in my opinion, the "change" element should be a button and not an anchor tag, because anchor tags are typically used to link to other pages or sections of a page, while buttons are used to trigger an action. In this case, the action is to change the plan of the order, so a button would be more appropriate.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0