Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I am proud of being able to complete this challenge.
What challenges did you encounter, and how did you overcome them?I didn't encounter any particular challenge.
What specific areas of your project would you like help with?I would need feedback on how to improve my code. Thanks!
Community feedback
- @grace-snowPosted about 1 month ago
Good job, this looks quite close to the design, just a bit smaller which is likely due to padding differences on the larger screen view.
One thing you definitely need to check is the html though. There are a few issues and questions for you:
- Alt text on images shouldn’t ever include the word “image” Because they are already on an element with an image role. You could say "illustration" perhaps but should be a little more descriptive of what this illustration looks like / is conveying if you think this is valuable content.
- Music icon is a decorative image so alt must be empty.
- Personally I would make annual plan a heading because it is acting as a heading for the content under it. The price then becomes a paragraph. (Remember you can use grid for the layout in that box if all elements are direct children or you can wrap those two bits of content in an extra element for layout with flex).
- Change plan must be an interactive element.
- It's not necessarily wrong but I'd like you to think carefully about the function of the interactive elements in this design. Forget about styling, just think about what they would do on click. Because that determines what elements you should be using in html. Should "change plan" be an anchor and should"proceed" be a button and what should "cancel" be? Think it through.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord