Design comparison
SolutionDesign
Solution retrospective
No issues in the code, just the exact position which I couldn't adjust correctly as appeared in the image given to me by the challenge and the colors which aren't in the styles document.
Community feedback
- @denieldenPosted over 2 years ago
Hi Kenzar, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility img
element must have analt
attribute, it's very important!- remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - for add the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- remove all
margin
fromcontainer
class because with flex they are superfluous - add
margin: 0
to body for remove the scroolbar of browser - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord