@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- For icons, you should still use the alt attribute, but it should be empty (
alt=""). This indicates to screen readers and other assistive technologies that the icon is decorative and that they should skip over it
- When you use the hover effect and
cursor: pointeron an element, it usually implies interactivity. To enhance user experience, consider wrapping the " Change" element in an<button>tag. This way, users can click on it, expecting some action.
- Prefer
min-height: 100vhoverheightto avoid cutting off components on smaller screens.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@vedant027
Posted
@MelvinAguilar Hey the only reason i didn't wrap the "Change" element inside a button tag was that while looking at the design prototype i didn't thought it is a button rather than a text ...but if i would have been adding some hyperlink to redirect the user on any other page i would have definitely used the button tag. BTW, Thankyou for taking out time and going through my code, really appreciate it. I would definitely keep in mind the things you have mentioned above while making my future projects.
