Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <h2> with < h1>, <h4> with <h2>, always the footer should be out of the main tag, Remove the footer that wrapping cancel order to fix the accessibility issue. and give <p> a class to style its content. for more on semantic html visit https://web.dev/learn/html/semantic-html/
For a responsive content in this challenge replace the width of the main with max-width and increase its value to match the width in the design.
You forgot to give the body a background-color, the background-color of the body is the background color you gave to the main. the background-color of the main is white.
give the img a max-width of 100% instead of width: 100% instead of a width and height value of 100% if there is a little space under the image , add display: block to the img.
In the media query change the background-size of the body to contain .
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord