Design comparison
SolutionDesign
Community feedback
- @CodeWithAlaminPosted almost 2 years ago
Hi jiju278👋 Great job on completing this challenge! 🥳
I noticed a few areas where your solution to the challenge could be improved, and wanted to share my suggestions with you.
- Instead of using a global selector (
*
) to apply box-sizing to all elements, you could use a more specific selector such ashtml
orbody
to avoid unnecessary style inheritance. For example:
html { box-sizing: border-box; }
- You could use the
rem
unit instead ofpx
for sizes to make your layout more responsive and scalable. For example:
.card { width: 18rem; }
- You could use the
em
unit instead of%
for font sizes to make them more flexible and relative to the parent element's font size. For example:
.header__title { font-size: 1.5em; }
Overall, this is a very well done solution to the challenge. I hope these suggestions help you improve your code and take it to the next level!
Hope I'm Helpful! 👍
Keep up the good work! 😊❤️
Marked as helpful1@jiju278Posted almost 2 years ago@CodePapa360 Thank you very much for your advice and your encouraging message. It is very motivating for the future 😊❤️
1 - Instead of using a global selector (
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord