Design comparison
SolutionDesign
Solution retrospective
Hi guys! Please let me know your feedback about my work. Thank you Fam!
Community feedback
- @denieldenPosted almost 2 years ago
Hello CodeWithSubaru, You have done a good work! 😁
Some little tips to improve your code:
- To add the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - use
img
element for the top image istead of a styleddiv
- use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - add
transition
on the element with hover effect
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful1@CodeWithSubaruPosted almost 2 years ago@denielden Thank you so much for this fruitful information! Have nice day!
0@denieldenPosted almost 2 years ago@CodeWithSubaru you are welcome and keep it up :)
Have nice day you too!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord