Travolgi 🍕• 31,420
@denielden
Posted
Hello CodeWithSubaru, You have done a good work! 😁
Some little tips to improve your code:
- To add the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - use
img
element for the top image istead of a styleddiv
- use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - add
transition
on the element with hover effect
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
1
CodeWithSubaru• 120
@CodeWithSubaru
Posted
@denielden Thank you so much for this fruitful information! Have nice day!
0
Travolgi 🍕• 31,420
@denielden
Posted
@CodeWithSubaru you are welcome and keep it up :)
Have nice day you too!
1