Order Summary Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • Not all images should have alt text. Music icon and the hero image are for decoration purposes only, so they can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:

  <img src="images/illustration-hero.svg" alt="" aria-hidden="true" class="header-image">
  <img src="images/icon-music.svg" aria-hidden="true" class="plan-image">
  

  If you want to learn more about the alt attribute, you can read this article.

  • Use min-height: 100vh on the body element to allow it to take up the full height and be centered vertically

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding and Happy New Year! 🎉🎊🎁

  Marked as helpful

  2

  ---

  

  Jork•230

  @jc-paduaPosted almost 2 years ago

  Thank you, @MelvinAguilar. I'll try it on my next project; it is very helpful for me. Thank you!

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class=" card-container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility

  To center .card-container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  You forgot to give .btn-blue a box-shadow.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Jork•230

  @jc-paduaPosted almost 2 years ago

  @Hassiai thank you. I've always forgot to put a min-height: 100vh and I'll try to apply more tags for fixing the web-accessibility of my project. Thanks!

  0