@MelvinAguilar
Posted
Hi there π. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
HTML:
- Use the
<main>
tag to wrap all the main content of the page instead of the<div>
tag. With this semantic element you can improve the accessibility of your page.
- Use the
<footer>
tag to wrap the footer of the page instead of the<div class="attribution">
. The<footer>
element contains information about the author of the page, the copyright, and other legal information.
- Not all images should have alt text. Music icon and the hero image are for decoration purposes only, so they can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img src="images/illustration-hero.svg" alt="" aria-hidden="true" class="header-image">
<img src="images/icon-music.svg" aria-hidden="true" class="plan-image">
If you want to learn more about the alt
attribute, you can read this article.
- Use
min-height: 100vh
on the body element to allow it to take up the full height and be centered vertically
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding and Happy New Year! πππ
Marked as helpful
@jc-padua
Posted
Thank you, @MelvinAguilar. I'll try it on my next project; it is very helpful for me. Thank you!