Skip to content
Submitted almost 2 years ago

Order Summary Componant

Abdulrhman Mohamed Soliman•390
@AbdulrhmanSoliman
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm really appreciate your feedback.

Community feedback

  • Sinisa Vukmirovic•1,690
    @SinisaVukmirovicPosted almost 2 years ago

    Hello!

    Here are some feedback and to fix errors in your report.

    This "Document should have one main landmark" means you are missing <main> semantic element in your html. Landmark just means element.

    This "All page content should be contained by landmarks" means all non-semantic elements should be inside of semantic elements, and not directly inside of <body> element.

    Try to use semantic elements in your HTML. More about semantic elements

    Also, it is a good practice to import google fonts in your CSS file, not HTML. You are setting "font-family" in the CSS, right? It makes sense to import it there, too.

    Hope this helps!

    Marked as helpful
    1
    Abdulrhman Mohamed Soliman•390
    @AbdulrhmanSolimanPosted almost 2 years ago

    @SinisaVukmirovic Thank you, of course I will use the landmarks as soon as possible in my next projects. Yes, you safe me importing google fonts in CSS is better than putting it into HTML it's a beautiful way.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord