Design comparison
Solution retrospective
Hello everyone, I just finished the Frontend Mentor order-summary-component-main challenge, please suggest to me , ways I can improve my code
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hello Oluwatobi, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
- Add a
background-repeat: repeat-x;
, the image will repeat on the horizontal axis, preventing it from breaking. - Add a
background-size: 100% 50vmin;
, the50vmin
will set its height as the page target, and100%
will make it stretch on the horizontal axis.
Feel free to choose one of the two!
This page doesn't even need a "h1" because it is just a component, as you are aware. because we don't know how crucial the site's other elements will be! However, it's always advisable to avoid accessibility errors, so I believe it would be beneficial for you to include a "h1" in this component. This is also a good practice for when you are creating larger websites, so don't worry if you forget to include a "h1".
<h1>Order Summary</h1>
The remainder is excellent.
I hope it's useful. 👍
0 - Add a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord