Design comparison
Solution retrospective
I'm waiting for your review
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hi Vlad, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:
- Add a
background-repeat: repeat-x;
, the image will repeat on the horizontal axis, preventing it from breaking. - Add a
background-size: 100% 50vmin;
, the50vmin
will set its height as the page target, and100%
will make it stretch on the horizontal axis.
Feel free to choose one of the two!
To improve the code structure wrap this div:
<div class="attribution">
with the semantic tag
footer
The rest is great!
I hope it helps... 👍
Marked as helpful1 - Add a
- @xTern44Posted almost 2 years ago
Everything looks fine except for the positionning of the container. I suggest you try these adjusments:
body { height: 100vh; position: relative; }
.container { position: absolute; top: 50%; left: 50%; transform: translate(-50%,-50%); }
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord