Order Summary Component -First Challenge

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi @eewa-SANJ 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • You made the design with the wrong image. The image "desktop-preview.jpg" is only useful to have a more presentable image of the challenge, it is useful if you want to place it in your readme.md, or share it, for example QR code component challenge by frontendmentor.io. To create your solution, you should base yourself on the following images: desktop-design.jpg and mobile-design.jpg. The main-card section is unnecessary.

  • Not all images should have alt text. The music icon and the ilustration hero are for decoration only, they have no additional meaning to the component, so it can be hidden for screen-readers if aria-hidden="true" is added and its alt attribute is left empty: <img class="image-music" alt aria-hidden="true" src="images/illustration-hero.svg">

  • The <p> elements that enclose the <a> links are unnecessary, you should use the same link element and style them as if they were a button. You can read more info here

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  2
• 

  Sanjeewa Marukona•200

  @eewa-SANJPosted almost 2 years ago

  Thank you for providing valuable feedback. I will make all the changes mentioned

  0