David• 8,000
@DavidMorgade
Posted
Hello Oluchi, congrats on finishing the challenge! great job in my opinion
You should try for desktop size using brackground-size: contain and remove the background-position it will get your BG image on the middle for 1400px+.
Also would like to recommend you using flex to center the component instead of just margins on your <div> you can get it easily with this on your body (remember to remove the margins):
body {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100vh;
}
With min-height: 100vh your body will wrap the whole screen, and then flex-box will center the children wich in this case is the whole card.
Hope my feedback helps you, if you have any questions don't hesitate to ask, great job
0
