responsive layout , css grid , flexbox

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag to fix the accessibility issue.

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body. instead of giving .container a margin value.

  For a responsive content, replace the width in .container with max-width and change height value to auto. The box-shadow has a wrong color.

  You forgot to add background-image, with a background size of contain and a background repeat of no repeat to the body. in the media query, you only change the background- image of the body.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0