Design comparison
Solution retrospective
bg's cause me issues sometimes -.-;
Community feedback
- @bilalturkmenPosted over 1 year ago
hi Aj, nice work.
you define background theme on tailwind config, but it seems little bit false. maybe you can try like below
backgroundImage: { "desktop-pattern": "url('/src/assets/pattern-background-desktop.svg')", "mobile-pattern": "url('/src/assets/pattern-background-mobile.svg')", },
and then you should update App.tsx like below
❌ delete all this div
update this line
with this ✅
<main className="flex justify-center items-center h-screen bg-[#e0e8ff] lg:bg-desktop-pattern bg-mobile-pattern bg-no-repeat bg-contain">
and this line
update with this ✅
</main>
because document should have one
main
landmark instead div.i hope these helpful 🙂
Marked as helpful1 - @visionedPosted over 1 year ago
Thanks, Bilal! Makes more sense after seeing it... I was like half way there, but it was late when I was doing this and getting frustrated. Conflicting information through searching around. No excuses.
Made your recommended changes, thanks for taking the time to pick the lines out of github, I appreciate that very much.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord