@MelvinAguilar
Posted
Hi @machadogustavo ๐, good job completing this challenge, and welcome to the Frontend Mentor Community! ๐
Here are some suggestions you might consider:
- Use
min-height: 100vh
tobody
selector, with this property you set a height and let the element grow even more if necessary. Your elements will also be vertically centered when you use this property. - The
<div class="attribution">
needs to be wrapped in a<footer>
element:
<footer class="attribution">
Challenge by ...
</footer>
- The music icon and the Hero Illustration are for decoration purposes only, so they could be hidden from screen readers by adding aria-hidden="true" and leaving its alt attribute empty:
<img src="./images/icon-music.svg" alt aria-hidden="true">
- The background property is shorthand for all the properties of the background.
Update the property to
background-image
so you don't override the background color:
/* background: url(./images/pattern-background-desktop.svg); <---- Before*/
background-image: url(./images/pattern-background-desktop.svg);
Or use all the properties in the background:
background: var(--Very-pale-blue) url(./images/pattern-background-desktop.svg) no-repeat left top/contain;
References:
I hope those tips will help you.
Good job, and happy coding!
Marked as helpful
@machadogustavo
Posted
@MelvinAguilar Thanks for the comments, I was having doubts about the min-height and the background, I will adjust, thank you very much!