Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Component

gustavoโ€ข 40

@machadogustavo

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@MelvinAguilar

Posted

Hi @machadogustavo ๐Ÿ‘‹, good job completing this challenge, and welcome to the Frontend Mentor Community! ๐ŸŽ‰

Here are some suggestions you might consider:

  • Use min-height: 100vh to body selector, with this property you set a height and let the element grow even more if necessary. Your elements will also be vertically centered when you use this property.
  • The <div class="attribution"> needs to be wrapped in a <footer> element:
<footer class="attribution">
   Challenge by ...
</footer>
  • The music icon and the Hero Illustration are for decoration purposes only, so they could be hidden from screen readers by adding aria-hidden="true" and leaving its alt attribute empty:
<img src="./images/icon-music.svg" alt aria-hidden="true">
  • The background property is shorthand for all the properties of the background. Update the property to background-image so you don't override the background color:
  /* background: url(./images/pattern-background-desktop.svg);  <---- Before*/
  background-image: url(./images/pattern-background-desktop.svg);

Or use all the properties in the background:

background: var(--Very-pale-blue) url(./images/pattern-background-desktop.svg) no-repeat left top/contain;

References:

I hope those tips will help you.

Good job, and happy coding!

Marked as helpful

2

gustavoโ€ข 40

@machadogustavo

Posted

@MelvinAguilar Thanks for the comments, I was having doubts about the min-height and the background, I will adjust, thank you very much!

0
Faisal Alharbiโ€ข 330

@LovelyFaisal

Posted

Hi @machadogustavo You've done great ๐Ÿ’ช

Here are some suggestions to improve your code:

  • To center the component using flexbox add this property min-height: 100vh; to body element

Click here for more information

Good job, and happy coding!

Marked as helpful

1

gustavoโ€ข 40

@machadogustavo

Posted

@LovelyFaisal Thanks for the feedback, I'm still learning the flexbox properties, I'll use your tip! thank you so much

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord