Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

orderSumaryComponent

@Adriangln11

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • The “illustration” and Music Icon serves no other purpose than to be decorative; they add no value. Their alt tag should left blank and have an aria-hidden=“true” to hide it from assistive technology.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • The only heading in this challenge is the ”Order Summary". Every other text should wrapped in a paragraph element.
  • The “Cancel Order” was created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The anchor tag will achieve this.

More Info:📚

MDN The Anchor element

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

Here are some examples that you can freely use:

Josh Comeau Reset

Eric Meyer Reset

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🎄🎁

Marked as helpful

0
Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="app"> with the main tag to fix the accessibility issues.

Change the background-size of the body to contain, add a media query to add the background-image for the desktop. you forgot to add a background-color to the body.

There is no need for the height in .app if you still want to add the height, give it a value of auto. use padding top and bottom values instead of height. increase the width value of .app for it equivalent to the width in the design.

Give .container a background-color of white. Add a padding bottom and top values to .button and give it a box-shadow

Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord