Design comparison
Community feedback
- @atif-devPosted almost 2 years ago
Hi Lisandra, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body> <main> ---your code here---- </main> <footer> </footer> </body>
(why
main
matters? Read here)-
In your README file of GitHub repo, just write about your workings and findings. Like how you have built the project, what new things you have learned or what kind of flow you have used etc. (README file is kind of guide for someone to find out how we have build the project)
-
Since we tackle responsive design in challenges so it is preferred to use
em
unit for padding and margin andrem
unit for font-size. For further info watch this video
Hope you will find this Feedback Helpful.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord