Design comparison
Community feedback
- @rayaattaPosted 10 months ago
Hello 👋Ivan Adamo, congratulations on completing this challenge 🎉
I have some suggestions you might find out interesting.
1 Since the illustration-hero image is decorative its alt attribute should be left empty.
"Images with no semantic meaning—such as those which are solely decorative—or of limited informational value, should have their alt attributes set to the empty string (""). " - Mdn webdocs
You can check out this article.
2 You used
width: 450px;
On the.card
This is okay but in case a screen is less than 450px wide then the card overflows the view port. You can make it more responsive by usingmax-width:min(90%,450px)
This means it is 450px but on smaller screens it only covers 90% of the width.I hope this helps 🙃
Your solution is awesome 👏,I like the way you used semantic markup 🤩
Happy coding bro✌️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord