Design comparison
Solution retrospective
Tell me what can I do better please
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “illustration” and Music Icon serves no other purpose than to be decorative; they add no value. Their
alt tag
should left blank and have anaria-hidden=“true”
to hide it from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1 - The “illustration” and Music Icon serves no other purpose than to be decorative; they add no value. Their
- @Nadine-GreenPosted almost 2 years ago
HEY JOHN!
I noticed that the screenshot generated does not match the website, to fix this you will have to generate a new screenshot, the button to do so should be located just above the screenshot itself.
HOPE I COULD BE OF HELP :)
HAPPY CODING!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord