css and html

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  • Not all images should have alt text. The illustration-hero and music-icon are for decoration purposes only. In this case, you can add aria-hidden="true" to the element and leave the alt attribute blank.

    Adding aria-hidden="true" to an image will prevent it from being read by screen readers. This is useful when the image is purely decorative and does not convey any information that needs to be communicated to the user.

    <img src="./images/illustration-hero.svg" alt aria-hidden="true" class="icon">
    

    You can read more about this here 📘

  • There is a debate about what is the best type of elements for this challenge, but in my opinion, the "change" element should be a button and not an anchor tag, because anchor tags are typically used to link to other pages or sections of a page, while buttons are used to trigger an action. In this case, the action is to change the plan of the order, so a button would be more appropriate.

  I hope you find it useful! 😄

  Happy coding!

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Wrap <div class="attribution"> in the footer tag to fox the accessibility issues.

  Add a background-repeat of no-repeat to the body. To center .card on the page using flexbox, replace the height in the body with min-height:100vh.

  You forgot to give .card-btn a box-shadow.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0