Order summary component

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 2 years ago

  Hello there, mgil! 👋

  Nice job on this challenge! 👏 Your solution looks great! 🙂

  A couple of things I suggest are,

  • Using a button element for the "Change" button rather than a span. 😉
  • Setting the width of the card component to 100% and then adding a max-width to it to prevent it from becoming too wide when there's extra space around it. This is often better than setting the width of the element to a fixed value or percentage because it'll ensure that the element only takes up as much space as it should be allowed to but also shrinks accordingly when the space around it shrinks (such as the width of the viewport decreases).
  • You can wrap the card component in an article tag to make your HTML a little more semantic. 😉

  Hope you find these suggestions helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0