Order Summary Componant

Community feedback

• 

  Liam Tanfield•260

  @TanDevvPosted over 1 year ago

  Hello, kays20! Good work on this one. I can give you a few suggestions regarding your code. :)

  • Try to refrain from using px units for everything, especially for font sizing. Use rem or em instead. Relative units such as rem and em can adapt to accessibility for when when the users change the browser's font size setting. Px units will always stay the same size as what you set it as.

  (You can read this article regarding which units suit your content)

  • Not mandatory but I suggest looking into if you would want to use a CSS reset whenever you start a new project. This can help you once it comes to styling all your fresh HTML, potentially lowering your chance of running into a lovely CSS snag.

  (There is a lot to choose, if you feel unsure which to use, my recommendation that I use at the moment — Josh Comeau - Custom CSS Reset)

  • Regarding this part of your code:

  @media (min-width: 375px) {
  	body {
  		background-image: url('../images/pattern-background-desktop.svg');
  	}
  

  I would suggest looking into the <picture> tag for when you need to provide different versions of the same image. It saves you having to use a media query.

  (For more information on using <picture>, you can read this article by MDN)

  • Lastly, I noticed in line 92 of your CSS stylesheet, you have a margin-top: 20px; that is commented out, did you forget to delete or un-comment it? :)

  PS: I would suggest reading through the accessibility report that has been automatically made for you and implementing their fixes into your future projects, especially the errors regarding alt text for <img> elements.

  I hope you find these suggestions helpful, overall good effort with this one! 😁

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="box"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  BG iMAGE 📸:

  • let me explain, How you can easily apply the background color with the svg they provided.

  ---

  • Add the following style rule to your css, and then experience the changes

  body {
      background: url(/pattern-background-desktop.svg), #E1E9Ff;
      background-repeat: no-repeat, no-repeat;
  }
  

  • Tip, Don't forget to generate a new screenshot after editing the css file

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0