@TanDevv
Posted
Hello, kays20! Good work on this one. I can give you a few suggestions regarding your code. :)
- Try to refrain from using
px
units for everything, especially for font sizing.Use rem
orem
instead. Relative units such as rem and em can adapt to accessibility for when when the users change the browser's font size setting. Px units will always stay the same size as what you set it as.
(You can read this article regarding which units suit your content)
- Not mandatory but I suggest looking into if you would want to use a CSS reset whenever you start a new project. This can help you once it comes to styling all your fresh HTML, potentially lowering your chance of running into a lovely CSS snag.
(There is a lot to choose, if you feel unsure which to use, my recommendation that I use at the moment ā Josh Comeau - Custom CSS Reset)
- Regarding this part of your code:
@media (min-width: 375px) {
body {
background-image: url('../images/pattern-background-desktop.svg');
}
I would suggest looking into the <picture>
tag for when you need to provide different versions of the same image. It saves you having to use a media query.
(For more information on using <picture>, you can read this article by MDN)
- Lastly, I noticed in line 92 of your CSS stylesheet, you have a
margin-top: 20px;
that is commented out, did you forget to delete or un-comment it? :)
PS: I would suggest reading through the accessibility report that has been automatically made for you and implementing their fixes into your future projects, especially the errors regarding alt text for <img>
elements.
I hope you find these suggestions helpful, overall good effort with this one! š