Design comparison
Solution retrospective
Welp, this is my first ever attempt at anything like this so I hope I got close enough for an absolute beginner. I already know my code is a mess but I definitely struggled with making the summary responsive and keeping it looking how it's supposed to. So if anyone could show me the way, I'd appreciate it. And any other pointers they'd like to tell me, I'm good with constructive criticism. Here's to building a new skill!
Community feedback
- @brodiewebdtPosted almost 3 years ago
As far as the accessibility warnings, change the Order Summary to an H1, and your Annual Plan text to an H2. Your pages should always have an H1 if possible. You may have to change the font size to fit the design. Wrap all of your main content in a Main tag and change the attribution div to a Footer and that will fix the accessibility warnings. Download AXE DevTools to check accessibility while you are coding. https://www.deque.com/axe/devtools/
Marked as helpful1 - @brodiewebdtPosted almost 3 years ago
I have a few suggestion to make that will make your design responsive and better looking. You should start coding mobile first 375px. Websites are naturally responsive and require less code to style them. Add Media Queries for the larger screen size. Your Media Query is not taking effect because the is been overwritten. Try not to add Heights on anything if you can. Adding this code in the body tag will center component in the screen, after you remove the Media Query on the body tag:
display: grid; justify-content: center; align-items: center; height: 100vh;
In your container you have a width of 25% which is squeezing the size of your card. Remove the width and the height from the card will make a big difference with this card. In the Figma file this card has a maximum width of 450px, so you can add a max-width of 450px to the container and it won't stretch.
Hope this helps.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord