Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Order Summary Challenge

@DevWanderson

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my second challenge solution, suggestions? Improvements?

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi Wanderson Guedes, how are you?

You did a great job on this challenge, I really liked the responsiveness of the project, but I have a few tips that I think you'll like:

1- Document should have one main landmark, you could have put all the content inside the main tag click here

I noticed that the image was not showing up, so I made a change to the code and it worked:

body { background: url(images/pattern-background-desktop.svg) hsl(225,100%,94%); background-repeat: no-repeat; background-size: 100% 50vmin; }

Test it in your code! The rest is great! Hope it helps... 👍

Marked as helpful

0
Lucas 👾 104,420

@correlucas

Posted

👾Fala Wanderson Guedes, tudo bem? Parabéns pelo desafio!

Acabei de ver sua solução e tenho algumas dicas pra melhorar o código e o design:

Eu vi que você usou id para estilizar o componente, não é uma boa ideia porque id é um seletor muito específico usado para forms e chamar blocos com Javascript. Em vez disso, use class para estilizar e deixe o id para coisas muito específicas.

Não é aconselhável usar IDs como seletores de CSS porque se outro elemento na página usar o mesmo estilo/semelhante, você terá que escrever o mesmo CSS novamente. Mesmo que você não tenha mais de um elemento com esse estilo agora, ele pode vir mais tarde.

👋 Espero ter ajudado e continue no foco!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord