Design comparison
SolutionDesign
Solution retrospective
Any general tips on code styling/best practices are always appreciated. I also used flexbox basically any time I needed to move a component around, wasn't sure if that's always ideal or not. Thanks!
Community feedback
- @OmarMAttia7Posted almost 3 years ago
Congratulations on finishing the challenge, Good job :).
I'd like to point out a couple of problems with your HTML markup:
- Your component should be wrapped inside a
<main>
element. Every HTML document should have a<main>
element. - The title of your document - in this case Order Summary - should be put inside an
<h1>
element, also every HTML document should have one.
Marked as helpful0 - Your component should be wrapped inside a
- @unexunderscorePosted almost 3 years ago
Hi there! Great work, just keep going!
Some remarks:
- Title (Order Summary) and the Annual Plan text should be different color (bluish).
- If you hover over your mouse on the change link, you should not see underline. (text-decoration: inherit; )
- Where the music icon and annual plan text etc. There should be a very light gray box around, check the design picture, you can see slightly.
- Box shadow under the card layout and the button. (Sample: box-shadow: 0 8px 16px 0 rgba(0,0,0,0.2);)
Keep coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord