Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
👋 Hi everyone! This is my solution for the order-summary challenge, nothing to be very pride of here but practice make perfect as they say
What challenges did you encounter, and how did you overcome them?🏋️ Not any challenge encoutered, my objective this time was to complete the challegnge as fast as I could
What specific areas of your project would you like help with?✍️ As usual If you notice anything please feel free to give out your tips
Community feedback
- @Zy8712Posted 8 months ago
Hi there! Your site looks pretty good, nice work!
Some things I noticed when testing your site:
- for certain screen sizes the background doesn't extend to fit the full size of the screen, this may be due to how you implemented your css for your site
- I would suggest making sure your "wrapper" class has a width of 100vw so that it extends the full size of the screen
- for the background image you can use
background-size: cover;so it fits the full background - one other thing would be to use more semantic tags such as
<main>instead of having all divs. This is for accessibility purposes
Hope you find this feedback useful 👍
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord