Order summary challenge

Community feedback

• 

  darryncodes•6,390

  @darryncodesPosted about 3 years ago

  Hi Stephane,

  Great solution, it looks really good.

  • you could clear up your accessibility report by making this <div class="container-sm"> a <main> tag. And consider using an <h1>

  Happy coding 🤙

  Marked as helpful

  0

  ---

  

  Stephane Jean•360

  @distephano30Posted about 3 years ago

  @darryncodes Thanks for the advice

  0
• 

  Manoj Kumar Singh•530

  @manojks092Posted about 3 years ago

  Hey Stephane, as you haven't uploaded your code in Github repository so i couldn't review your code, still you did good work, though you need to work in the responsive part of the CSS, as you resize the screen you'll notice that the page or the card isn't responding relevant to the size of the screen, somewhere it's covering full page somewhere its having proper view(for example when width is **1044x670 ** then its covering whole page and at 1067x670 then card is small). Probably you created the page for the desktop first and then tried to change its size for different devices, so in my opinion you should try mobile first approach , this will help you a lot. And use flexbox or grid.

  I know its lot to digest, but still its just few code lines that you can update and fix it. All the best.

  Marked as helpful

  0

  ---

  

  Stephane Jean•360

  @distephano30Posted about 3 years ago

  @manojks092 thank you. Exactly I created the desktop version first. I will try the mobile first approach now. Thanks again for the review

  0