Aman Singh Bhogal• 1,010
@asbhogal
Posted
Hi Oscar,
This is great work, well done! The design matches the mockup well. Just a few things I've noticed which are worth considering for refactoring:
- It's best to use the
picture
element to handle responsive images, instead of the CSSbackground-image
property. Here's a good article from MDN explaining how to do this Link - You can simplify your code by removing the
section
container, applying these properties to themain
and just having the twodivs
inside this instead (since it's good practice to have both themax-width
andwidth
properties on a parent container) - Always locally host your Google Fonts for privacy and performance reasons. Here's a good video by Kevin Powell which shows how to do this Link
- At 320px your
main
container touches the viewport boundary. It would be worth adding apadding
ormargin
to the sides just to give them some spacing
Hope this helps!
0