Submitted almost 3 years ago
Order summary card with pure HTML and CSS
@Miguelo0098
Design comparison
SolutionDesign
Solution retrospective
Are CSS class names correctly chosen? Is the CSS stylesheet well structured? Is the HTML semantically good?
Community feedback
- @pikapikamartPosted almost 3 years ago
Hey, really nice work on this one. Layout in general looks great and it is adaptive for small screen-sizes.
Some suggestions on the site would be:
overflow-y
not needed on thebody
tag.- The vector/illustration being used in here is only a decorative image. You only want to include a descriptive
alt
value for images that are meaningful and add content to the site. If you look at this one, it doesn't really complement the site at all right. So usingalt=""
andaria-hidden="true"
to theimg
tag or onlyaria-hidden="true"
if you are usingsvg
instead ofimg
tag. - Also when using
img
tag, you don't need to add words that relates to "graphic" such as "logo" and others, sinceimg
is already an image so no need to describe it as one. - The annual-plan text could use a heading tag since it gives information on what the section would contain, hence the pricing plan. An
h2
would be great. - Either using
a
tag orbutton
on this one could be think of like this. If you are using aform
, thenbutton
is your choice sincebutton
are for controlling. If not usingform
maybea
tag is fine since it will just redirect the user back whatever choice they made.
Aside from those, the site is really great and the markup looks great as well. Nice solution on this.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord