Design comparison
Solution retrospective
- What did you think of my solution?
- Do I need to improve anything?
- I would really like your feedback.
- I'm not using preprocessors yet, I want to know a little about the difficulties of css without preprocessors and then start studying about them.
- I think I did something wrong with the responsiveness of the site, I don't know, I had to reset a lot of sizes,
font-size
and other things. Is there a better way or did I really do it the wrong way?
Community feedback
- @correlucasPosted over 2 years ago
👾 Fala Mateus, beleza? Parabéns pela sua solução.
Acabei de ver aqui e você reproduziu o design certinho.
Só tem um problema com sua solução, ela não está responsiva devido ao grande número de elementos que você colocou
width
ao invés demax-width
e ai o container se comporta como um block fix. Pra resolver esse problema você tem que ajustar todos os width pra max width permitindo o container a diminuir quando a janela se ajusta.Se você arrumar isso nem vai precisar de nenhum media query, o proprio container se ajusta sozinho.
Se você quiser ver minha solução pra saber como vai ficar depois do ajuste responsivo, tá aqui o link: https://www.frontendmentor.io/solutions/order-summary-component-vanilla-css-custom-wave-background-hover-tEKUwaT2id
Espero ter ajudado, continue codando bro
Marked as helpful1@Theuz1nh0Posted over 2 years ago@correlucas Thank you very much, I will give a solution and my solution
1 - @fatlindshehuPosted over 2 years ago
Hi @Theuz1nh0,
You did a very good job, congrats on that, I think it would be easier for you to make the component responsive if you choose between
rem or em
and avoid usingpx
, I personally userem
because their base font-size isroot
font-size which is 16px, and based on that I can convert all mypx
units intorem
s, I would suggest:- In smaller screens give the component a margin so the browser doesn't overflow the content
- Use a media query to make the component and its elements smaller on small screen devices.
Keep it up...
Marked as helpful1@Theuz1nh0Posted over 2 years agoHi @fatlindshehu, first thank you very much for your feedback.
- I did this I used the
rem
andem
measurements in almost all my measurements (except for the edge measurements), but what I found strange is that when I went to the mobile version I had to redo these values, as it was a little different than expected. So, sort of in the media query, I had to change just a few measurements. - About giving margin on smaller screens I had completely forgotten, and I even found it strange that when I was leaving the screen small to test, it would "eat" my project. I will do what you said, thank you very much.
0@fatlindshehuPosted over 2 years ago@Theuz1nh0 You should choose between
rem or em
but not both,rem
uses as a base font-size the root font-size (16) meanwhileem
base font-size is its parent font-size (which in some cases can be challenging to know where is cascading from).Keep it up bro :)
1@Theuz1nh0Posted over 2 years ago@fatlindshehu So I did like this... The
width
of my parent element which is themain
tag I put it inem
and the rest of the measures, minus thefont-size
measures I putrem
. Is what I did right? Or even thefont size
measurements need to be inrem
too?0@fatlindshehuPosted over 2 years ago@Theuz1nh0 If you choose
rem
then everything is supposed to be inrem
that's the proper way of doing that, in the case of image width/height then the percentage is used.1 - @fausto-machavaPosted over 2 years ago
Verry well done, its amazing!
1 - @mubizzyPosted over 2 years ago
Excellent job on this challenge!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord