Design comparison
Solution retrospective
Trying to use the SVG was the more time consuming part. I had to remove the original height/width and add a viewBox with the height/width. Is that generally how to work with SVGs or is there a better/easier way?
Community feedback
- @denieldenPosted almost 3 years ago
Hi Rai, great job! Congratulations on completing the challenge.
SVG offers the advantage of being able to be used as code... but you can also use it as if it were an image.
Add
main
tag and wrap the card for AccessibilityFor fix the top image in the background just put more specific background properties to the body:
background: url("../img/pattern-background-desktop.svg") no-repeat top center; background-size: contain; background-color: #e0e8ff;
Overall you did well :)
Hope this help and happy coding!
Marked as helpful0@RaiIsNotYourGuyPosted almost 3 years ago@denielden Thanks for the feedback. I added the main tag to the newest challenge I completed, definitely got back alot less accessibility issues. I will try the background image css idea next time I run into a SVG.
1 - @EmmanuelHexerPosted almost 3 years ago
Great work overall man. Keep it up
- To fix your accessibily issues wrap your card with
main
element.
Marked as helpful0 - To fix your accessibily issues wrap your card with
- @NaveenGumastePosted almost 3 years ago
Hay ! Rai Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body
<main class="container"></main>
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord