Order Summary card w/ flex and grid

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey, some suggestions to improve you code:

  • Picture Element is being used incorrectly and it not needed for this challenge.

  • The “Illustration” and Music Icon serves no other purpose than to be decorative; It adds no value. The Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • Your "button" was created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  Happy Coding! 👻🎃

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @AlexAgustini, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  Your background is applied but it's not too similar to the design yet. Add background-size: contain instead of background-size: cover to make it display the size full width and center with the card vertically. Note that now is slightly different from the challenge design.Here’s the code with the modification and the image applied as background:

  body {
      display: flex;
      justify-content: center;
      align-items: center;
      background-image: url(pattern-background-desktop.svg);
      background-size: contain;
      background-repeat: no-repeat;
      background-color: #E1E9FF;
  }
  

  ✌️ I hope this helps you and happy coding!

  0