Design comparison
SolutionDesign
Solution retrospective
Like always, any and all comments are welcome.
Community feedback
- @denieldenPosted over 2 years ago
Hi Nebil, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - Centering a
div
withabsolute
positioning is now deprecated, it uses modern css likeflexbox or grid
- try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - try to add a little
transition
on the element with hover effect
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1 - remove all unnecessary code, the less you write the better as well as being clearer: for example the
- @NaveenGumastePosted over 2 years ago
Hello Nebil Nejmudin ! Congo π on completing this challenge
Let's look at some of your issues, shall we:
-
Payment button text is just white color.
-
annual plan bg color is given in the style-guide.md
happy Codingπ
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord